Replace href value using javascript

I have the following code which changes the big image according to the thumbnail clicked (this part is working).

I want to change accordingly the url in the href (so that each big image shown has a link to another URL). <-- this last part is not working.

----------HERE IS THE CODE ----------------------

asked Jan 19, 2014 at 22:06

1

This question might get flagged as a duplicate, but here's the answer anyway.

To change the href value of an anchor:

document.getElementById('file').setAttribute('href',url);

answered Jan 19, 2014 at 22:08

SchienSchien

3,7171 gold badge15 silver badges29 bronze badges

7

You need to change logic slightly...Thumbnails doesn't have links, right?

Html:

answered Jan 19, 2014 at 22:42

sinisakesinisake

11k2 gold badges18 silver badges27 bronze badges

2

I ran the code in Firebug, and found the error:

   th=document.getElementById('thumbs').getElementsByTagName('img');
for(c=0;c

"this" refers to th[c], and now look at your image tags:

They don't have href attribute, so your swapFile function fails and terminates script execution. You could add custom attributes to these images:

But images are not anchors, so th[c].href will not give you the value.

Here's the new init function:

function init(){

   th=document.getElementById('thumbs').getElementsByTagName('img');

for(c=0;c

I have tested the code locally and it runs.

answered Jan 19, 2014 at 22:52

SchienSchien

3,7171 gold badge15 silver badges29 bronze badges

answered Nov 13, 2021 at 7:21